fix correctness bugs across core, JsonPath, Xml and FSharp#378
Merged
SimonCropp merged 2 commits intoJul 6, 2026
Merged
Conversation
fix correctness bugs across core, JsonPath, Xml and FSharp Add regression tests (src/ArgonTests/BugFixes/, NullTokenTests.fs) and fix: core writer/reader - JsonConvert.ToString(TimeSpan) escaped the whole stack buffer, embedding NULs - JsonWriter.WriteValue(StringBuilder) wrote each chunk as a separate JSON string - JsonTextWriter.WriteValue(char) ignored QuoteValue/QuoteChar - JsonTextReader.Close() double-returned charBuffer to ArrayPool on a second call - JsonReader.SetUndefinedToken set Null instead of Undefined serializer - JsonConverter<T>.ReadJson returned null on container tokens without consuming them - OrderByKey packed the comparer into the sort key, making ordering culture-sensitive - JsonSerializerProxy did not forward ResolveContract or Converters to converters - CreateProperties used unstable List.Sort, scrambling order for >16 props with Order - removed duplicate EncodingConverter registration utilities - GetDefaultValue(char) returned boxed int 0 so DefaultValueHandling.Ignore missed chars - BoxedPrimitives.Get(decimal) dropped the sign of negative zero - ISO parser accepted out-of-range zone offsets, throwing from the DateTimeOffset ctor linq - CompareBigInteger inverted comparisons against negative fractions - GetHashCode/GetDeepHashCode were inconsistent with Equals across numeric types - TryAddInternal advanced the index when a child insert was skipped - implemented JObject IDictionary.Values (was NotImplementedException) jsonpath - FieldMultipleFilter threw ErrorWhenNoMatch even when the property existed - numeric filter literals were not terminated by && or || - $[-1] crashed instead of returning null fsharp - FSharpList/FSharpMap converters crashed on a JSON null xml - single-element nested arrays lost json:Array for prefixed/encoded names - multiple sibling comments serialized to "#comment": [], dropping the text - CreateXmlDocumentType discarded the DTD internal subset - #cdata-section/#text with a null value crashed for XDocument
SimonCropp
deleted the
fix-correctness-bugs-across-core,-JsonPath,-Xml-and-FSharp
branch
July 6, 2026 10:07
This was referenced Jul 6, 2026
Closed
Closed
This was referenced Jul 7, 2026
Bump Argon, DiffEngine, EmptyFiles, Verify and Verify.NUnit
VerifyTests/Verify.Sylvan.Data.Excel#115
Closed
Closed
Closed
Bump Argon, DiffEngine, EmptyFiles and Verify
NServiceBusCommunity/NServiceBus.Community.Serilog#864
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix correctness bugs across core, JsonPath, Xml and FSharp
Add regression tests (src/ArgonTests/BugFixes/, NullTokenTests.fs) and fix:
core writer/reader
serializer
utilities
linq
jsonpath
fsharp
xml