Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't delay loading node.exe due to imported data #92

Closed
wants to merge 1 commit into from

Conversation

tvald
Copy link

@tvald tvald commented Mar 15, 2017

Because CustomeExternalStringResource extends V8's ExternalStringResource, it imports the vftable which prevents delayed loading of node.exe. Attempting to build the module with node-gyp results in the error LNK1194

LINK : fatal error LNK1194: cannot delay-load 'node.exe' due to import of data symbol '"__declspec(dllimport) const v8:
:String::ExternalStringResource::`vftable'" (__imp_??_7ExternalStringResource@String@v8@@6B@)'; link without /DELAYLOAD
:node.exe [D:\tmp\lmdb\node-lmdb\build\node-lmdb.vcxproj]
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Program Files (x86)\Yarn\node_modules\node-gyp\lib\build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:194:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Windows_NT 10.0.14393
gyp ERR! command "C:\\Program Files (x86)\\nodejs\\node.exe" "C:\\Program Files (x86)\\Yarn\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd D:\tmp\lmdb\node-lmdb
gyp ERR! node -v v7.7.2
gyp ERR! node-gyp -v v3.5.0
gyp ERR! not ok
error Command failed with exit code 1.

Further discussion:
nodejs/node#1266 - flag to disable delayed load
nodejs/node-gyp#599 - background
nodejs/node#751 - technical details
nodejs/node#1251 - technical details

@tvald
Copy link
Author

tvald commented Mar 16, 2017

This is a duplicate of #91.

@tvald tvald closed this Mar 16, 2017
@Venemo
Copy link
Owner

Venemo commented Mar 18, 2017

@tvald Thanks! #91 has been merged now - hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants