Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arith: fix some constructor issues. #955

Merged
merged 1 commit into from
Jun 25, 2021
Merged

arith: fix some constructor issues. #955

merged 1 commit into from
Jun 25, 2021

Conversation

philmb3487
Copy link
Contributor

Here is a patch regarding a few issues with the way arith_uint256 is used.
The constructor is called directly to set the initial value, and there's a typo in the name of a class.

@Zannick
Copy link
Collaborator

Zannick commented Jun 3, 2021

utACK 8eb0add
(I guess we're not compiling with USE_NUM_OPENSSL or we might have caught the misnamed function.)

Copy link
Collaborator

@CaveSpectre11 CaveSpectre11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 8eb0add

@CaveSpectre11 CaveSpectre11 added Tag: Waiting For QA A pull review is waiting for QA to test the pull request Tag: Waiting For Code Review Waiting for code review from a core developer labels Jun 12, 2021
@codeofalltrades codeofalltrades merged commit 5ed54a1 into Veil-Project:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tag: Waiting For Code Review Waiting for code review from a core developer Tag: Waiting For QA A pull review is waiting for QA to test the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants