[Utils] Templatify AssertLockHeld to placate clang warning #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By changing the type of the lock from void* (which has no capability) to the actual type (which does). Minimize the amount of code we have to move into sync.h by pointing the AssertLockHeldInternal template at the original function that takes void*.
CaveSpectre11
added
the
Tag: Waiting For Code Review
codeofalltrades
added
Code Review: Passed
Tag: Waiting For QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By changing the type of the lock from void* (which has no capability) to the actual type (which does).
(Templates more or less have to be defined in a header, included in a header, or specializations explicitly declared in a header, so the actual implementation here is to call the original function that took a void*.)
Test Results
Built and run veild/veil-cli with clang. Built veild/veil-cli with clang with
-DDEBUG_LOCKORDER.