Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI] Capitalize First Letter in Menu Option Words #917

Merged
merged 1 commit into from
Apr 10, 2021
Merged

[GUI] Capitalize First Letter in Menu Option Words #917

merged 1 commit into from
Apr 10, 2021

Conversation

Rock-N-Troll
Copy link

@Rock-N-Troll Rock-N-Troll commented Apr 2, 2021 •
edited
Loading

(Recreated branch due to commit issue)

Existing:
image

New:
image

@CaveSpectre11
Copy link
Collaborator

Please squash your commits

@codeofalltrades
just settingswidget changes default
d9720e3 
Capitalize in translations. addresses Unlock Wallet For Staking
additional changes to make unlock for staking capitalized
@Rock-N-Troll Rock-N-Troll force-pushed the capitalize_menu_items branch from 38591a1 to d9720e3 Compare April 3, 2021 23:56
@Rock-N-Troll
Copy link
Author

somehow I manage to always get coat's last commit involved, but hopefully shouldn't be an issue here

@CaveSpectre11 CaveSpectre11 added Component: GUI Primarily related to the display of the user interface Tag: Waiting For Code Review Waiting for code review from a core developer labels Apr 4, 2021
CaveSpectre11
CaveSpectre11 reviewed Apr 4, 2021
View reviewed changes
Copy link
Collaborator

@CaveSpectre11 CaveSpectre11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what happened here:

image

src/qt/veil/balance.cpp
posx = widget->pos().rx()+150;
posx = widget->pos().rx()+190;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this is covered in your description of what was done.

codeofalltrades
codeofalltrades approved these changes Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@codeofalltrades codeofalltrades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d9720e3
Tested in Win10

@codeofalltrades codeofalltrades merged commit ddd0b15 into Veil-Project:master Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaveSpectre11 CaveSpectre11 CaveSpectre11 left review comments

@codeofalltrades codeofalltrades codeofalltrades approved these changes

@WetOne WetOne Awaiting requested review from WetOne

Assignees

@Rock-N-Troll Rock-N-Troll

Labels
Component: GUI Primarily related to the display of the user interface Tag: Waiting For Code Review Waiting for code review from a core developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rock-N-Troll @CaveSpectre11 @codeofalltrades