-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RPC] Return mining addresses in listaddresses rpc command #911
[RPC] Return mining addresses in listaddresses rpc command #911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Adjusted the PR text to be contained rather than just a link to the obsolete PR)
utACK 6a00e1a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Adjusted the PR text to be contained rather than just a link to the obsolete PR)
utACK 6a00e1a
On this testnet wallet I'm not getting all the addresses with a balance.
|
In my testing, it seems to be related to address book only. Maybe that assumption needs to be changed |
List Addresses command is designed to only display addresses in the wallet address book
So it looks like the functionality is correct or at least adheres to the existing expectation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 6a00e1a
listaddresses
RPC command now handles mining addresses in the listaddresses commandAddresses issue: #863