-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RPC][Mining] Add sanity checks to generatecontinuous #879
Conversation
33b63d5
to
b654113
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK b654113
This is going to take some digging, and probably outside the scope of the PR. We'll need to figure out why |
Little bit of research shows that hardware_concurrency returns the number of concurrent threads the system has; and can often be 2x the number of cores; but it's OS specific. So I might need to tweak the wording here a little bit. |
b654113
to
6cc4d59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 6cc4d59
Note
This is built on top of #878 and requires code added in #877 and #878
Problem
generatecontinuous
can get users in trouble by not knowing what their settings will do to their resourcesSolution
Add checks in
generatecontinuous
:Testing