Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced FAQ Section: Updated Staking, Mining, and General Guidance #1043

Merged
merged 11 commits into from
Feb 3, 2025

Conversation

ohcee
Copy link
Contributor

@ohcee ohcee commented Jan 22, 2025

What’s Changed:

Staking Instructions:

    Detailed and clarified the steps for staking, including converting Basecoin to Stealth, Stealth to RingCT, and RingCT to Zerocoin.
    Provided guidance to access additional resources for advanced staking methods.

Mining Guidance:

    Added updated links to recommended miners for ProgPoW, RandomX, and mining proxy setups.
    Included FastPool as a mining pool option for RandomX.
    Clarified that SHA-256d mining is wallet-only and offered relevant instructions.

General Improvements:

    Removed references to autominting, aligning the content with its default disabled state.

Bounty Program Section:

    Updated the section to reflect the inactive status of the bounty program.
    Invited community contributions and directed users to Veil GitHub issues for ideas and tasks.

Why This Improves the Wallet:

Clarity: Improves user understanding with step-by-step instructions and streamlined language.
Accuracy: Reflects the latest features and operational practices within the Veil ecosystem.
Community Engagement: Encourages user participation in Veil’s development via GitHub.
Ease of Use: Provides direct links to resources for mining and configuration.

Testing and Validation:

Verified all functional links and ensured they direct users to the correct resources.
Ensured consistency with current wallet functionality and ecosystem resources.

@ohcee ohcee marked this pull request as draft January 26, 2025 05:00
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose some changes for clarity or simplicity, and for capitalisation consistency in the names of veil coins vs Veil, the Project, with bolding used in these cases for emphasis rather than capitalisation.
(See attached text file.)
ProposedLine36ofSettingsFAQ04.txt

Copy link
Collaborator

@seanPhill seanPhill Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed capitalisation changes were for consistency with the web site style guide and with our general usage in discussions on Discord or other Internet venues. I noticed that these were not necessarily inconsistent with the rest of the in-wallet FAQs, so that part is not important. Please review the suggestions here, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been updated to the current suggestion.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. It's a big improvement in clarity.

Copy link
Collaborator

@seanPhill seanPhill Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am proposing additional changes for correction and clarity. For example, "Exchanges and Services mode" should never have been called "Exchange or Service mode", and other wording implies that RingCT is less private than zerocoin, an unnecessary confusion for users. (See the attached text file.)
ProposedLine36ofSettingsFAQ06.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been updated to the current suggestion.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! :)

@seanPhill seanPhill marked this pull request as ready for review January 30, 2025 23:43
Copy link
Collaborator

@seanPhill seanPhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem. Let's go.

@seanPhill seanPhill merged commit 471fba9 into Veil-Project:master Feb 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants