Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] Return RandomX seed and ProgPow epoch also if no miningaddress is set #1022

Merged

Conversation

us77ipis
Copy link
Contributor

@us77ipis us77ipis commented Nov 4, 2022

The getblocktemplate rpc, should always include the RandomX seed (if a RandomX template is requested) and the ProgPow epoch (if a ProgPow template is requested), also if no miningaddress was specified in the config.

@us77ipis us77ipis changed the title [RPC] Return RandomX seed also if no miningaddress is set [RPC] Return RandomX seed and ProgPow epoch also if no miningaddress is set Nov 5, 2022
Copy link
Collaborator

@Zannick Zannick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK df354a8

@barrystyle
Copy link

Wouldn't this be a bit pointless if pprpcheader isn't returned?
This hash cannot be calculated without the miningaddress set, as it is required for the coinbase transaction to be formed in CreateNewBlock (in miner.cpp).

@us77ipis
Copy link
Contributor Author

For example a mining pool which builds the blocks from scratch needs the epoch information but not the pprpcheader nor does it need to set a miningaddress in the daemon because it is set externally while building the coinbase transaction like you said.

@seanPhill seanPhill merged commit d8bfddb into Veil-Project:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants