Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mining][RPC] Fix getnetworkhashps rpc #1020

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

us77ipis
Copy link
Contributor

@us77ipis us77ipis commented Nov 1, 2022

The hashrates returned by the getnetworkhashps rpc were always wrong, because the calculation was based on the entire work of the chain (including all three mining algos and also proof-of-stake).

Fixes #1018

@us77ipis us77ipis force-pushed the master branch 2 times, most recently from a61ad99 to 98ffd43 Compare November 2, 2022 10:21
src/rpc/mining.cpp Outdated Show resolved Hide resolved
The hashrates returned by the `getnetworkhashps` rpc were always wrong,
because the calculation was based on the entire work of the chain
(including all three mining algos and also proof-of-stake).

Fixes Veil-Project#1018
Copy link
Collaborator

@Zannick Zannick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 15eeef7

@seanPhill seanPhill added the QA: Pending QA is waiting a response/confirmation from developers label Dec 21, 2022
@seanPhill seanPhill added QA: Passed This has passed QA testing and can be merged to master and removed QA: Pending QA is waiting a response/confirmation from developers labels Jan 31, 2023
@seanPhill
Copy link
Collaborator

I've been running this for some weeks.

@seanPhill seanPhill merged commit f264a1d into Veil-Project:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA: Passed This has passed QA testing and can be merged to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][RPC][Mining] The network hashrate returned by getmininginfo rpc is wrong
3 participants