Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate CI workflows #645

Merged
merged 10 commits into from
Jun 26, 2024
Merged

Separate CI workflows #645

merged 10 commits into from
Jun 26, 2024

Conversation

amrit110
Copy link
Member

PR Type ([Feature | Fix | Documentation | Test])

CI

Short Description

Currently the CI workflows are taking too much time. These are mainly the docs (build) and docs deploy workflows. The time consumed is mainly from running the notebook tutorials. In this PR we improve this situation by:

  1. Separating out the unit tests and coverage calculation into a normal unit test workflow
  2. Creating a single workflow for building docs and deploying them. This was achieved using event trigger if statements. This workflow does not run the nbsphinx notebooks.
  3. Creating a new separate workflow which only runs for release PRs (looks at the release label). It also deploys to github pages once the PR is merged.

Also changed the docs and release docs workflows to run in the github CI runner. So, only the integration tests run on the self-hosted runner.

Tests Added

...

@amrit110 amrit110 self-assigned this Jun 26, 2024
@amrit110 amrit110 added the ci Changes to github actions label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.27%. Comparing base (40a7c21) to head (9af671d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #645   +/-   ##
=======================================
  Coverage   75.27%   75.27%           
=======================================
  Files         128      128           
  Lines       11473    11473           
=======================================
  Hits         8636     8636           
  Misses       2837     2837           

see 1 file with indirect coverage changes

Impacted file tree graph

@amrit110 amrit110 marked this pull request as ready for review June 26, 2024 14:31
@amrit110 amrit110 requested a review from fcogidi June 26, 2024 14:31
.github/workflows/unit_tests.yml Outdated Show resolved Hide resolved
.github/workflows/docs.yml Show resolved Hide resolved
.github/workflows/code_checks.yml Outdated Show resolved Hide resolved
@amrit110 amrit110 merged commit 9b9a47b into main Jun 26, 2024
8 checks passed
@amrit110 amrit110 deleted the improve_ci_workflows branch June 26, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants