Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evaluate api endpoint for server based deployment #640

Merged
merged 19 commits into from
Jun 27, 2024

Conversation

amrit110
Copy link
Member

@amrit110 amrit110 commented Jun 18, 2024

PR Type ([Feature | Fix | Documentation | Test])

Deployment

Short Description

  • Add a fastapi server endpoint for evaluation
  • The server script serves as an example
  • Move the models deployment example to a new directory
  • Adjust optional dependencies in pyproject.toml for deployment of models and report

Tests Added

...

@amrit110 amrit110 self-assigned this Jun 18, 2024
@amrit110 amrit110 added the enhancement New feature or request label Jun 18, 2024
@amrit110 amrit110 requested review from fcogidi and rjavadi June 22, 2024 03:38
@amrit110 amrit110 marked this pull request as ready for review June 22, 2024 03:39
@amrit110 amrit110 changed the title Add evaluate api endpoints for server based deployment Add evaluate api endpoint for server based deployment Jun 22, 2024
@fcogidi
Copy link
Collaborator

fcogidi commented Jun 24, 2024

I'm not able to get the server running locally with either fastapi dev (there is some issue with uvicorn) or fastapi run (the error is about a missing jinja template).

deploy/report/api/main.py Outdated Show resolved Hide resolved
@rjavadi
Copy link
Collaborator

rjavadi commented Jun 24, 2024

I receive null when I post the example request to server.
Server returns 200 OK.
Update: Got it, then I have to use browser and go to /evaluate to see updated report.

Looks good to me.

@amrit110 amrit110 merged commit b75ad23 into main Jun 27, 2024
9 checks passed
@amrit110 amrit110 deleted the feature/web-dashboard-api branch June 27, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants