Skip to content

Add thumb2 mrc il #6640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonathanzetier wants to merge 2 commits into from
Closed

Add thumb2 mrc il #6640

jonathanzetier wants to merge 2 commits into from

Conversation

@jonathanzetier
Copy link
Contributor

@jonathanzetier jonathanzetier commented Apr 14, 2025

This PR:

  • Updates an outdated README (build instructions seem to be from the era when the arch was a separate repo).
  • Makes a minor change to disassembly: using the same rX for register names as everywhere else did in MRC disassembly rather than RX, which makes it possible to see the source of register values when a register is highlighted.
  • Adds IL to the MRC/MRRC/MCR/MCRR (and *2 variants) in thumb mode. Nothing too fancy here, the intrinsics were already implemented for ARM mode, so this was just bringing them over to thumb mode too.

@jonathanzetier
Update README.md
6871bc7 
It looks like the build instructions hadn't been updated after the arch
plugins were moved back to binaryninja-api.
@jonathanzetier
Add IL for thumb2 CP instructions
87a7de5
@CLAassistant
Copy link

CLAassistant commented Apr 14, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@galenbwill galenbwill self-assigned this Apr 14, 2025
@galenbwill galenbwill added Type: Enhancement Component: Architecture Issue needs changes to an architecture plugin Arch: ARM/Thumb Issues with the ARM/Thumb architecture plugin Lifting issues related to LLIL lifting labels Apr 14, 2025
@galenbwill galenbwill added this to the H milestone Apr 14, 2025
@galenbwill
Copy link
Contributor

galenbwill commented Apr 14, 2025

Thanks for your submission. I will review this after the 5.0 release is done.

@galenbwill
Copy link
Contributor

galenbwill commented May 27, 2025

Please accept the CLA. I will merge this as soon as you have. Thanks again for the PR!

@galenbwill galenbwill added State: Blocked (Customer) Issue is blocked on waiting for a response from a customer Impact: Low Issue is a papercut or has a good, supported workaround Effort: Low Issues require < 1 week of work labels May 27, 2025
@galenbwill galenbwill modified the milestones: Future, Helion May 27, 2025
@galenbwill galenbwill removed the State: Blocked (Customer) Issue is blocked on waiting for a response from a customer label Jun 2, 2025
@galenbwill
Copy link
Contributor

galenbwill commented Jun 2, 2025

Merged and should be in builds >= 5.1.7551-dev.

@galenbwill galenbwill closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@galenbwill galenbwill

Labels

Arch: ARM/Thumb Issues with the ARM/Thumb architecture plugin Component: Architecture Issue needs changes to an architecture plugin Effort: Low Issues require < 1 week of work Impact: Low Issue is a papercut or has a good, supported workaround Lifting issues related to LLIL lifting

Projects

None yet

Milestone

Helion

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathanzetier @CLAassistant @galenbwill