Add function caller_sites verification in python api #6475
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR! It's a good idea however there's actually another approach we might need to implement but I'd have to double check the implementation. I believe the correct approach is to actually walk the IL in the first place of each caller_function and first check if it's an LLIL call and then return it. I'd have to dig up a sample that replicates it though to verify whether that is a better approach or not. Either way there's no reason not to at least add this. Do you mind renaming |
Contributor
Author
|
No worries, I was tired when I made this PR |
Member
|
I'm adding this separately with the requested variable name change. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3722