Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attempt to enforce ipv4 in postfix #1116

Merged
merged 1 commit into from
Mar 4, 2017
Merged

Commits on Mar 4, 2017

  1. Remove attempt to enforce ipv4 in postfix

    In #420, we added a line to provisioning that attempts to set
    "ipv4" as the only allowed protocol for postfix due to issues in
    how network connections managed the ipv6 connection.
    
    Because the config file does not yet exist during initial
    provisioning, that caused an error message saying as much. See #628.
    
    It turns out that this line hasn't been doing anything. :)
    
    I first went down the path of using `debconf-set-selections` to
    set the protocol value. This works, but then disables ipv6 entirely
    as a valid protocol. Since we haven't heard of any other issues
    besides the original in #420, I think it's safe to not make any
    change here and then watch for any problems.
    
    I have a feeling that postfix has gotten better about this. In the
    documentation for the `inet_protocols` config, it's mentioned that
    "versions before 2.8 attempt to connect via IPv6 before attempting
    to use IPv4."
    
    http://www.postfix.org/postconf.5.html#inet_protocols
    
    Now that we're past 2.8, it's entirely possible that the protocol
    detection has gotten better. If we do run into an issue, there is
    a newer `smtp_address_preference` config that allows us to specify
    which protocol should be attempted first.
    
    http://www.postfix.org/postconf.5.html#smtp_address_preference
    
    In that case, we may need to create our own custom config file as
    it's not entirely obvious that `debconf-set-selections` will work
    for this value.
    
    See #420.
    Fixes #628.
    jeremyfelt committed Mar 4, 2017
    Configuration menu
    Copy the full SHA
    a41ac4b View commit details
    Browse the repository at this point in the history