Conversation
There was a problem hiding this comment.
Pull request overview
This is a major refactoring PR that migrates the Rust MCP Server from the rust-mcp-sdk (version 0.7.0) to the newer rmcp library (version 0.11.0), implementing the MCP 2025-11-25 protocol version. The changes involve a complete architectural overhaul of how tools are defined and registered, removal of resources and prompts functionality, and implementation of self-contained documentation generation.
Key Changes
- Migration from
rust-mcp-sdktormcplibrary with updated error handling and type system - Complete refactoring of tool implementation using new trait-based architecture (
ToolImplandTooltraits) - Removal of experimental features: resources (Cargo Book documentation) and prompts functionality
- Introduction of built-in documentation generation capability (replacing external
mcp-discoverytool) - Removal of timeout configuration option from command-line arguments
Reviewed changes
Copilot reviewed 39 out of 40 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.rs | Migrated to new rmcp API, added documentation generation mode, removed timeout argument |
| src/version.rs | New file extracting version handling logic |
| src/tool.rs | New file implementing tool trait system and command execution |
| src/rmcp_server.rs | New file implementing the MCP server handler with tool registration |
| src/tools/*.rs | Refactored all tool implementations to use new ToolImpl trait pattern |
| src/serde_utils.rs | Updated error types from CallToolError to ErrorData |
| Cargo.toml | Updated dependencies, removed unused crates, bumped rust-version to 1.90 |
| tools.md | Updated to reflect removal of prompts and resources |
| README.md | Updated command-line arguments documentation |
| Removed files | Deleted resources.rs, prompts.rs, handler.rs, scripts, docker files, and prompt templates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.