Skip to content

Commit

Permalink
chore: removes GetComponentDevFlags as it is exported field of the st…
Browse files Browse the repository at this point in the history
…ruct (opendatahub-io#591)

and it is already accessed this way.
  • Loading branch information
bartoszmajsak authored Oct 4, 2023
1 parent 2522ad3 commit 6ea3441
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 29 deletions.
4 changes: 0 additions & 4 deletions components/codeflare/codeflare.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ func (c *CodeFlare) OverrideManifests(_ string) error {
return nil
}

func (c *CodeFlare) GetComponentDevFlags() components.DevFlags {
return c.DevFlags
}

func (c *CodeFlare) SetImageParamsMap(imageMap map[string]string) map[string]string {
imageParamMap = imageMap
return imageParamMap
Expand Down
1 change: 0 additions & 1 deletion components/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ type ComponentInterface interface {
ReconcileComponent(cli client.Client, owner metav1.Object, DSCISpec *dsci.DSCInitializationSpec) error
GetComponentName() string
GetManagementState() operatorv1.ManagementState
GetComponentDevFlags() DevFlags
SetImageParamsMap(imageMap map[string]string) map[string]string
OverrideManifests(platform string) error
}
4 changes: 0 additions & 4 deletions components/dashboard/dashboard.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,6 @@ func (d *Dashboard) OverrideManifests(platform string) error {
return nil
}

func (d *Dashboard) GetComponentDevFlags() components.DevFlags {
return d.DevFlags
}

func (d *Dashboard) SetImageParamsMap(imageMap map[string]string) map[string]string {
imageParamMap = imageMap
return imageParamMap
Expand Down
4 changes: 0 additions & 4 deletions components/datasciencepipelines/datasciencepipelines.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ func (d *DataSciencePipelines) OverrideManifests(_ string) error {
return nil
}

func (d *DataSciencePipelines) GetComponentDevFlags() components.DevFlags {
return d.DevFlags
}

func (d *DataSciencePipelines) SetImageParamsMap(imageMap map[string]string) map[string]string {
imageParamMap = imageMap
return imageParamMap
Expand Down
4 changes: 0 additions & 4 deletions components/kserve/kserve.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,6 @@ func (k *Kserve) OverrideManifests(_ string) error {
return nil
}

func (k *Kserve) GetComponentDevFlags() components.DevFlags {
return k.DevFlags
}

func (k *Kserve) SetImageParamsMap(imageMap map[string]string) map[string]string {
imageParamMap = imageMap
return imageParamMap
Expand Down
4 changes: 0 additions & 4 deletions components/modelmeshserving/modelmeshserving.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@ func (m *ModelMeshServing) OverrideManifests(_ string) error {
return nil
}

func (m *ModelMeshServing) GetComponentDevFlags() components.DevFlags {
return m.DevFlags
}

func (m *ModelMeshServing) GetComponentName() string {
return ComponentName
}
Expand Down
4 changes: 0 additions & 4 deletions components/ray/ray.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@ func (r *Ray) OverrideManifests(_ string) error {
return nil
}

func (r *Ray) GetComponentDevFlags() components.DevFlags {
return r.DevFlags
}

func (r *Ray) SetImageParamsMap(imageMap map[string]string) map[string]string {
imageParamMap = imageMap
return imageParamMap
Expand Down
4 changes: 0 additions & 4 deletions components/workbenches/workbenches.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,6 @@ func (w *Workbenches) OverrideManifests(platform string) error {
return nil
}

func (w *Workbenches) GetComponentDevFlags() components.DevFlags {
return w.DevFlags
}

func (w *Workbenches) GetComponentName() string {
return ComponentName
}
Expand Down

0 comments on commit 6ea3441

Please sign in to comment.