Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add code coverage support for ghdl #627
add code coverage support for ghdl #627
Changes from 7 commits
bb1c1cf
d076065
fdc43ce
a8d098c
73798cb
bbc33a7
2a28310
d9b8a1d
eff4b8e
2050d53
178637f
628627a
3d6c3e2
f4d371b
9f53776
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To follow the convention in e.g. modelsim.py:258 this option should be moved to the ghdl interface class and be enabled based on the
enable_coverage
sim option.Maybe
ghdl.a_flags
should be handled the same way. For riviera and modelsim the user has to manually set compile option since they have to make a decision on what coverage to enable. For ghdl that choice is not there, soghdl.a_flags
could be set in the class solely based onenable_coverage
sim option.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my original idea, but I opted not to do it as it seems like the
enable_coverage
sim option should not affect compilation.But it would be more convenient, I'll change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sim option
-Wl,-lgcov
, has now been moved intoghdl.py
The compilation function only works on the
SourceFile
object, which is neat but means that theenable_coverage
simulation option is not conveniently available. I've added a newenable_coverage
compilation option. This also means that coverage may be enabled only for the desired files. Proof of concept on my tsfpga branch