style: merge data_types/src/types/* into data_types/src/types.vhd #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are two files with 5 lines each. When byte_vector is added in #507, there will be three. Apart from being short, the content is tightly related. As proposed in #507, a single
types_pkg
package is defined, and all the types are put there.Moreover, as commented in #507, the definition of
byte_t
is moved fromverification_components/**/memory_pkg.vhd
to thisdata_types/**/types.vhd
.Also, in #507,
type storage_mode_t is (internal, extfnc, extacc);
is defined instring_ptr_pkg.vhd
. This type is to be later used byinteger_vector_ptr_pkg.vhd
(#476) andmemory_pkg.vhd
(#470). Therefore, it makes sense to makebyte_t
andstorage_mode_t
available in a similar fashion.