Sarang87 #13
Open
Sarang87 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fectly on my local machine and changed some parts to use different css classes from google-scholar web page to retrieve the result set with cited count and related count correctly
…ing code. index_sarang87.js is the working code without the throttle queue and index_throttled_q.js is the working code with the throttled queue which is very slow
|
Hi - I know this is unrelated to your commit but I'm not sure where else to look for help. Do you have any way around the CORS policy issue described here: #12 ? I'm trying to use this to integrate Google Scholar search into our app but if I'm reading other information correctly it looks like Google Scholar doesn't allow API searches... how are you using this package? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have made my changes for you to review. I have included 3 index.js files
index_original.js => Original file from the google-scholar master which has the Cited count issue.
index_sarang87.js => File with fixed cited count issue for you to review. I have removed the throttled queue which is slowing down the performance considerably.
index_throttled_q.js => File with fixed cited count issue with the throttled queue to stop from getting blocked.
If it would be possible to retain the throttled queue while having a minimal impact on retrieval times for results that would be ideal.
Regards,