add s390x support for REH #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasgrapentin
commented
Nov 9, 2024
daiyam
reviewed
Nov 9, 2024
andreasgrapentin
force-pushed
the
master
branch
from
a998a84 to
383d9fd
Compare
|
Can you replace the |
|
paths to docker container and sysroot (and shasum) have been updated in fc309f1 |
|
The archives are available. |
|
Thanks guys for your work on this! (now I only need access to one of those s390x machines with a C compiler on, preferably the IBM one ... ) |
it's slightly off-topic for this issue, but you can request access to s390 machines with Linux in the LinuxOne cloud free of charge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends VSCodium by adding s390x (IBM Mainframe / System Z) to the list of valid targets for the remote extension host.
This is mostly straightforward and very similar to the other supported architectures, with one difference that is required in the dependency tree of vscode, where web-tree-sitter needs to be updated to work around an endianness issue.
The CI components as used in this PR are currently still built in my forked version of vscode-linux-build-agent, but I have created a separate PR for that repository here: VSCodium/vscode-linux-build-agent#24, if that is merged, then the paths used here can be updated accordingly.
I have been using a manually built and installed version of the REH for a few weeks now, and have not noticed any issues or regressions.