Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check both arm64 and aarch64 #2041

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

Suyun114
Copy link
Contributor

No description provided.

@Suyun114 Suyun114 changed the title fix: arm64 -> aarch64 for parsing uname -m fix: check both arm64 and aarch64 Sep 24, 2024
@daiyam
Copy link
Member

daiyam commented Sep 24, 2024

@Suyun114 Can you confirm it's to build on Linux+ARM?

@Suyun114
Copy link
Contributor Author

@Suyun114 Can you confirm it's to build on Linux+ARM?

I tried to use the previous script to build on Linux ARM64, and I found that codium became an x86-64 binary.

@daiyam daiyam merged commit 5e4ba54 into VSCodium:master Sep 25, 2024
21 checks passed
@Suyun114 Suyun114 deleted the arm64-aarch64 branch September 27, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants