Request: disable more telemetry-related prefs by default

[Tiagoquix]

In https://github.com/VSCodium/vscodium/blob/master/update_settings.sh, I think some settings should be removed and new ones added. I don't quite understand its structure, so I'm opening an issue instead of a pull request.

Overview of what should be changed

The following settings should not be used, and, therefore, should be removed if present:

telemetry.enableTelemetry
telemetry.enableCrashReporter

They are deprecated with a new telemetry setting called telemetry.telemetryLevel.
telemetry.telemetryLevel should be set to off.

telemetry.editStats.enabled could be disabled by default. Even though its description says it will only send if general telemetry is enabled, you never know what Microsoft is going to do next.

telemetry.feedback.enabled could also be disabled by default.

workbench.settings.enableNaturalLanguageSearch is disabled by default. In addition, workbench.commandPalette.experimental.enableNaturalLanguageSearch could be disabled by default as well.

Finally, on stable releases, workbench.enableExperiments could be disabled as well. As I understand it, it's some kind of "try beta features while sending metrics to us". I think this should not be disabled on Insider builds as I believe that could have an impact.

Then, after all of this (if it's approved), I'll send a PR to update the telemetry docs. I currently have one open: #2500
but if the update script is changed with the changes I suggested here, then I will do another PR to update the telemetry docs as well.

Thanks!

[daiyam]

The telemetry is also disabled by updating the callback domain (from *.data.microsoft.com to 0.0.0.0, https://github.com/VSCodium/vscodium/blob/master/undo_telemetry.sh)

update_setting "${TELEMETRY_CONFIGURATION}" src/vs/platform/telemetry/common/telemetryService.ts does apply to telemetry.telemetryLevel

But I will review the new settings, and maybe change that file to a .patch file where the changes are easier to track.

[daiyam]

I will leave telemetry.feedback.enabled enabled by default since it would have disabled the "Report Issue" menu.

[daiyam]

I've made the .patch at #2502

I also disabled telemetry.editStats.enabled and workbench.commandPalette.experimental.enableNaturalLanguageSearch

[Tiagoquix]

I will leave telemetry.feedback.enabled enabled by default since it would have disabled the "Report Issue" menu.

Does that affect extensions too? If not, I think it's safe to disable as well, since I guess most users of VSCodium would prefer to fill manual bug reports by acessing the github repo.

I've made the .patch at #2502

I also disabled telemetry.editStats.enabled and workbench.commandPalette.experimental.enableNaturalLanguageSearch

Thanks! telemetry.enableTelemetry and telemetry.enableCrashReporter are deprecated, but fine for me if you want to keep them just in case.

What about workbench.enableExperiments?