Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need for "i" flag on a numerical only regex #995

Merged
merged 1 commit into from
Oct 26, 2016
Merged

No need for "i" flag on a numerical only regex #995

merged 1 commit into from
Oct 26, 2016

Conversation

stefanoio
Copy link
Contributor

Yay! We love PRs! 🎊

Please include a description of your change and ensure:

  • [√] Commit message has a short title & issue references
  • [√] Each commit does a logical chunk of work.
  • [√] It builds and tests pass (e.g gulp)

More info can be found on our contribution guide.

@rebornix
Copy link
Member

@stefanoio nice catch!

@rebornix rebornix merged commit ee58aa5 into VSCodeVim:master Oct 26, 2016
@stefanoio stefanoio deleted the patch-2 branch October 26, 2016 21:15
@xconverge
Copy link
Member

xconverge commented Oct 26, 2016

@stefanoio Thanks! Did you test this out a little bit since you reported the issue? Did it meet your needs?

@stefanoio
Copy link
Contributor Author

stefanoio commented Nov 1, 2016

@xconverge sorry for the delay, right now it works great, there's still a really minor glitch I can explain with a simple example:
margin: 1em 2em;, when the cursor is positioned after the 1 and before the 2 the number affected by the C-a or C-x should be the 2 (it should be always the number underneath the cursor or the next one on the same line), but it's the 1 instead on VSCodeVim v0.4.1.
Should I report it somewhere else? Thank you!

@xconverge
Copy link
Member

hmm can you file an issue for this? It is a tough one

I am not sure how to fix this immediately while also keeping hex and octal support...

@stefanoio
Copy link
Contributor Author

Sure. Anyway it's just a minor glitch, not really critical IMHO. Thank you!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants