Numbered, upper case and multicursor register #974
Conversation
| /** | ||
| * Puts the content at the specified index of the multicursor Register. | ||
| * | ||
| * `REMARKS:` This Procedure asume that you pass an valid register. |
There was a problem hiding this comment.
Same spelling mistake in the other comments as well.
| // Check if appending to a multicursor register or normal | ||
| if (typeof appendToRegister.text === "object") { | ||
| if (appendToRegister.registerMode === RegisterMode.CharacterWise && currentRegisterMode === RegisterMode.CharacterWise) { | ||
| (appendToRegister.text as string[]).forEach(element => { |
There was a problem hiding this comment.
Why not move this outside the if block as it's the same as line 218.
| Register.registers[register].text = text; | ||
| } | ||
| // Harmonize newline character | ||
| text = text.replace(/\r\n/g, '\n'); |
There was a problem hiding this comment.
Can we read files.eol to use the proper line ending of the file? https://code.visualstudio.com/Docs/customization/userandworkspace
There was a problem hiding this comment.
These lines only apply when we read from the system clipboard. The problem is vscode automaticaly transforms \n to \r\n when your EOL is set to CRLF, so when we're on a windows machine the EOL is \r\n if i would paste that vscode transforms it to \r\r\n and you've got two linebreaks in the editor.
My first idea was to get the current EOL setting from the active editor but i didn't found the vscode API, you can set it but i don't found where i can read the setting???
As i can't go that way, my next idea was check the OS if we're on windows replace the newline char with the vscode-vim internal newline ('\n' we use it everywhere), but then i thought safe me the check and replace it everytime because on windows it fixes the double newline and on unix systems it causes no harm because there is no \r\n in the clipboard.
What do you think, is it better to add the OS check so it is more obvious that it should only apply to windows machines?
There was a problem hiding this comment.
The following should work:
let eol = vscode.workspace.getConfiguration('files').get("eol", "\n");
and then you can add this as a new member to configuration.ts to expose it to your current functionality.
There was a problem hiding this comment.
So when i think about it the "The default end of line character" (comment for the setting) is not the problem, i would need the "current system clipboard end of line character" because i had to romve the \r only on windows because vscode adds it when \n is inserted. And in case of unix system replacing \n with \n is unnecessary.
See the behavior i get on my machine (WIN7 with EOL = CRLF):
Every replace i do the \n is turned into \r\n so \n is the universial newline character in vscode?
There was a problem hiding this comment.
Ah, very interesting behaviour. I repro that on my mac and I see what you mean, in that case using \n is the way to go.
|
Thanks @Platzer! |
Implements basic functionality for numbered registers (#500)
0for last yanked text1to9delete historyImplements appending to register with uppercase letter
singletosinglecursor registersingletomulticursor registermultitomulticursor register (if line count match)Closes PR #918 because i was to stupid to rebase that branch...