New increment without separators #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xconverge
commented
Oct 19, 2016
| let newNum = input; | ||
|
|
||
| // Only use this section if this is a number surrounded by letters | ||
| if (findNondigits.exec(input) !== null && NumericString.matchings[NumericString.matchings.length - 1].regex === regex) { |
There was a problem hiding this comment.
Would like feedback on how I can get an ID to only run this for 1 of the 4 regex situations
There was a problem hiding this comment.
What do you mean? I don't understand.
There was a problem hiding this comment.
Right here I am only doing this logic if it is the last regex in the list (none of the others matched, so the last one is a catchall for anything that contains any number) It seems like a hack to depend on the last regex in the list to be this catchall...
|
This should be good to go unless someone has some more feedback, I tested it a bit more and am happy enough with it |
|
LGTM. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay! We love PRs! 🎊
Please include a description of your change and ensure:
gulp)More info can be found on our contribution guide.
@sectioneight @johnfn took another stab at this one, last attempt was #661