Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw multicursor correctly in Visual Mode #920

Merged
merged 2 commits into from
Oct 14, 2016

Conversation

Platzer
Copy link
Contributor

@Platzer Platzer commented Oct 14, 2016

Please include a description of your change and ensure:

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp)

I did not create an issue for that, so here is the thing. In Visual Multicursor Mode no decorator for multicursor where drawn, and also the selection start was not drawn correctly.

gif

Now it looks like:
gif

@Platzer Platzer changed the title Draw multicursor Draw multicursor correctly in Visual Mode Oct 14, 2016
@xconverge
Copy link
Member

Awesome! I love these types of changes. They definitely help polish things up

@xconverge
Copy link
Member

Does this make sense for Visual block mode as well?

@johnfn johnfn merged commit 5d9f2b0 into VSCodeVim:master Oct 14, 2016
@johnfn
Copy link
Member

johnfn commented Oct 14, 2016

Yeah, this one looks good to me. :)

@Platzer Platzer deleted the draw-multicursor branch November 3, 2016 06:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants