Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update internal cursor position per Code selection change #919

Merged
merged 1 commit into from
Oct 14, 2016

Conversation

rebornix
Copy link
Member

Yay! We love PRs! 🎊

Please include a description of your change and ensure:

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp)

More info can be found on our contribution guide.

@xconverge
Copy link
Member

Does this fix a problem and then create all of the original problems that we closed before we made this change? It makes sense to me, but I imagine some of the issues closed from the other day will reopen.

@rebornix
Copy link
Member Author

let me give them a quick check.

@rebornix
Copy link
Member Author

Verified #872 #877 #882 #892 #895 #896, they are still good.

Verified #856, which we claimed it was fixed while actually it was still half broken without this PR.

#901 I'm not sure if I'm doing the right keystrokes, on both Master and my PR, it still doesn't work.

@xconverge
Copy link
Member

LGTM then, thanks for checking those

What portion of the code was causing #882 then...

@johnfn
Copy link
Member

johnfn commented Oct 14, 2016

@xconverge I think the problem was that it would always go into that complex selection logic and eventually trigger updateView. Now that happens much more rarely.

So I think we're good here.

@johnfn johnfn merged commit c20a663 into VSCodeVim:master Oct 14, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants