fix cursor position after entering command mode (again) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,6 +37,7 @@ export default class CommandMode extends Mode { | |||
|
|
|||
| ShouldBeActivated(key : string, currentMode : ModeName) : boolean { | |||
| if (key === 'esc' || key === 'ctrl+[') { | |||
| this.caret.reset().left().move(); | |||
There was a problem hiding this comment.
Ah! Thanks! Can you actually move this to HandleActivation()?
kimitake
force-pushed
the
fix-cursor-pos-after-entering-command-mode
branch
from
8e88a08
to
9c93b3a
Compare
jpoon
added a commit
that referenced
this pull request
Dec 3, 2015
…mmand-mode Fix cursor position after entering command mode
|
Thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after merged Refactor motion. #87, this process was discarded.