Unnecessary quit check on untitled files #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't the next check here be checking if the file isDirty? That doesn't seem to be working when I make an untitled file and type some stuff in it and then do :q |
|
Thats there because VIM also do nothing when you try to But i think the |
|
If I open vim, and have an empty file, and do :q, it will quit... |
|
Yes you are right, it is a unnecessary check. |
|
LGTM. |
|
That being said, the isDirty check that comes after this seems to be funky..I will look into it |
|
@xconverge I take it that's a separate issue and this can be merged, correct? |
|
Yep! |
|
Awesome, thanks @xconverge! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a reason this was here? This PR is more of a question, but could be merged if it makes sense...
Shouldnt :q on a new untitled file work? On MacVim if I open it and immediately do :q it quits
This is also causing #846