Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce suggestion #85

Closed
wants to merge 1 commit into from
Closed

Conversation

kimitake
Copy link
Contributor

@kimitake kimitake commented Dec 2, 2015

When inputting, the suggestion window is displayed, but sometimes it is unnecessary.

@kimitake kimitake force-pushed the reduce-suggestion branch 5 times, most recently from c99930c to 16fa288 Compare December 3, 2015 23:23
@jpoon
Copy link
Member

jpoon commented Dec 4, 2015

This still doesn't fix the actual issue. I have filed -- microsoft/vscode#997 against vscode for this.

@kimitake
Copy link
Contributor Author

kimitake commented Dec 4, 2015

Yes, but much better than current one. At least, editor.action.triggerSuggest should be called in "then" method, otherwise any suggest window won't be displayed during inputting (it is displayed when hit backspace).

@jpoon
Copy link
Member

jpoon commented Dec 4, 2015

At least, editor.action.triggerSuggest should be called in "then" method, otherwise any suggest window won't be displayed during inputting (it is displayed when hit backspace).

If you want to update the PR to only address this, I can merge that.

I am hesitant to take this PR as a whole as it's a hack that only serves as a band-aid fix. I'd like to see VSCode's response to microsoft/vscode#997 before we decide how to address overzealously displaying the suggest window.

@kimitake
Copy link
Contributor Author

kimitake commented Dec 4, 2015

As you said, the best solution is the fix you request above, but if the fix is merged, we will see a lots of suggest window and can't write code easily using the vim plugin...so I also wait for the response microsoft/vscode#997 and your decision.

@kimitake kimitake closed this Dec 5, 2015
@kimitake kimitake deleted the reduce-suggestion branch December 5, 2015 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants