Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X eats eol #827

Merged
merged 3 commits into from
Oct 4, 2016
Merged

X eats eol #827

merged 3 commits into from
Oct 4, 2016

Conversation

xconverge
Copy link
Member

This one was actually super annoying, let me know what you think of the way I addressed it. The original report was from user iivvoo on slack

"since we're talking about obscure issues: In vscode you can click one character past the last character (sort of the newline character?)
[6:30]
x-ing it will join two lines
[6:31]
sometimes I click way past the characters to the right to put the cursor at the end, 'x'-ing to remove the last character doesn't have the expected behaviour"

Yay! We love PRs! 🎊

Please include a description of your change and ensure:

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp)

More info can be found on our contribution guide.

…e end of the line, also fixes pressing x when in this situation and it joining lines by accident
@johnfn
Copy link
Member

johnfn commented Oct 4, 2016

This looks good to me. Thanks for fixing this annoying issue, @xconverge! :)

@johnfn johnfn closed this Oct 4, 2016
@johnfn johnfn reopened this Oct 4, 2016
@johnfn johnfn merged commit 4602ae7 into VSCodeVim:master Oct 4, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants