zz in visual, visualline, and visual block mode #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnfn
requested changes
Oct 3, 2016
| keys = ["z", "z"]; | ||
|
|
||
| public async exec(position: Position, vimState: VimState): Promise<VimState> { | ||
| // In these modes, you want to take the full selection and find the middle point |
There was a problem hiding this comment.
Are you sure? For me, zz just centers on the active cursor.
There was a problem hiding this comment.
Apparently I made up functionality, I am not sure how I tested it but it was wrong. Thanks for carefully checking what I am actually doing....
|
I think it's sufficient to add all visual modes to the mode list for zz. |
|
Good stuff! Thanks for your work, @xconverge! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay! We love PRs! 🎊
Please include a description of your change and ensure:
gulp)More info can be found on our contribution guide.