Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up typings #818

Merged
merged 1 commit into from
Oct 2, 2016
Merged

Clean up typings #818

merged 1 commit into from
Oct 2, 2016

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Oct 2, 2016 •
edited
Loading

  • What started as a small itty bitty change in extension.ts ended up with a full cleaning of our typings
  • Clean up typings. Namely, typescript definitions should not be included in the source. They are defined in typings.json and installed with npm install

@johnfn
Copy link
Member

johnfn commented Oct 2, 2016

LGTM. I actually checked in the typings a while back because we had some stuff that hadn't been added to the official typings, but that's no longer the case.

@johnfn johnfn merged commit cff9a34 into master Oct 2, 2016
@jpoon
Copy link
Member Author

jpoon commented Oct 2, 2016

Thanks @johnfn!

@jpoon jpoon deleted the small_fix branch October 2, 2016 22:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpoon @johnfn