Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Pipeline #788

Merged
merged 2 commits into from
Sep 20, 2016
Merged

Release Pipeline #788

merged 2 commits into from
Sep 20, 2016

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Sep 19, 2016

On a successful build of the release branch, Travis will:

  1. Create a GitHub release uploading the packaged vsix
  2. Publish the new version to the marketplace

Moving forward, for pushing a release, it will be:

  1. merge master to release branch
  2. git tag/gulp release and git push origin --tags


env:
global:
secure: F3+6ObO8G2XDTXXSWizxdV4YzjWWwFKfISwYnKTwnAy4LXLPzcHnrh31rFmKeXSddZmWiVMhy++a4Y9IOTi0DrSnUYaaIP35zMIvMYIqdSa6v3b93Z0fwZmniXe0e4EBIhcdnMOz1fdxGhd0oWP/YyywOm32TjymhqbApT9AzqUodpGqRmA30B1tOFr09K+A2EiIr+4QGsB/a3VUv24zWWUHtkXaJ6tQ7rqt6944tGK4RtjAIzXLoePjJ+kmTqY6fMk/sPmYxHXnzjaEsIFBd5dYDCFtjR0oqjdq2OXc+bwIjl4t3Wh4RwE8bUEcUSnkPRqlJH5Hni5vfPRirb4qH4uoFmLNa8Pg2dPI44cYBvWVGSJ5GqXD5jV64waR3CM3VC2Ll76KWdlqdUo0cNIV75ul+UdieuNghTnw3OTYIWyhvrLqfnabOG81z09brNapZuCPj3rZ+sjTWf7beRoH877UGH0C6jimxNk0syjGL0+pXH0UR0dI+7RWaNyPAMfvjz3m9UpDw3NtdDGNMT1D3VgZz+INwU6XMUSpg36S1BzMTfi6NJm+srA5BDHyC/MuYjO+l/1gaj0+dvkpMyyj9btotYFmfemEFlm2AHGMkITaucUrmCQKIM9ZL7l/fZfvPkUGbaaLH7EONL7KLLaj6pk2z7na91/3I1pWg4yJDPE=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite sure but is it possible to put the key in Travis env instead of here?

Copy link
Member Author

@jpoon jpoon Sep 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they would have the same effect. (https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings)

I would prefer putting it in this manner as then our configs are in one central location and not scattered about and my plaintext keys are not stored anywhere.

Copy link
Member

@johnfn johnfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really awesome! Can you please just add a little to a readme file somewhere documenting how to push a release? Since it's just going to be shared amongst the contributors, you don't have to go into that much detail. (I assume you just push to release and that's it?)

@jpoon
Copy link
Member Author

jpoon commented Sep 20, 2016

@johnfn I simplified the release workflow removing the need to manage a release branch. Added instructions to the contributing.md.

In order to push a new release, all that is needed is to create a git tag. there's a helper function provided in the gulpfile for doing so: gulp patch|minor|major which will rev the package.json version as well as apply a git tag.

Travis will then:

  1. build
  2. test
  3. publish the new version to the marketplace
  4. create a GitHub release uploading the generated vsix

@johnfn
Copy link
Member

johnfn commented Sep 20, 2016

LGTM. Thanks for maintaining our infra, @jpoon! It's a big help. :)

@jpoon jpoon merged commit 73dedd2 into master Sep 20, 2016
@jpoon jpoon deleted the add_release_pipeline branch September 20, 2016 06:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants