Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build on extension/test launch #755

Merged
merged 1 commit into from
Sep 12, 2016
Merged

build on extension/test launch #755

merged 1 commit into from
Sep 12, 2016

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Sep 11, 2016

Request for comment cc: @johnfn @rebornix

Force a build via gulp on extension launch/test. I tend to forget to run gulp watch manually; often times I would change the source, run it, and wonder why the behaviour didn't change before the duh moment.

With this change,

  • Pro: Guaranteed that the TS is compiled; no need to run gulp watch or npm compile manually and check console if things compiled correctly. auto-runs tslint.
  • Con: Adds build time (5s right now) before you can launch the extension/run tests

@rebornix
Copy link
Member

LGTM. I put the check in pre-commit but definitely this change is necessary.

@jpoon jpoon merged commit bb9ede4 into master Sep 12, 2016
@jpoon jpoon deleted the auto-build branch September 12, 2016 05:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants