Read command

[domgee]

Initial support for read and read!.

Vim documentation, read
Vim documentation, read!

Range and opt arguments are not yet implemented.

[rebornix]

Indent :)

[rebornix]

Thanks for taking things that are currently not on our list :) Just drop some comments and can you update the roadmap in your PR as well, especially add Note to it if child-process is not OS-compatible (I'm not sure).

[domgee]

I've updated the roadmap and dropped one comment at least :)

[jpoon]

Is there an issue tracking this with VSCode? Some initial Google says there's some config at the workspace level where you can set the encoding. Maybe we can read that config?

[jpoon]

@dominic31 awesome work! dropped a few comments.

[domgee]

@jpoon thanks for the comments! I've left some replies.

[jpoon]

LGTM.

• If you choose not to include the detection of the current file encoding, can you file a separate issue so we can track it?
• Update the test

[domgee]

I've updated the unit test.

About the encoding, there's an open issue on the VS Code project for supporting encoding related functions through the api. It hasn't got past the backlog yet. Shall I open an issue here that refers to that issue?

[jpoon]

Yes please!

One last thing, can you merge with master and resolve the conflicts?

[domgee]

Sorry, I've gotten things a little muddled up here, the encoding parameter in fs.readFile() is of course the encoding of the external file that gets read in, not the current file in VS Code. Looking at the vim docs for read (link in the first comment), the encoding can be specified in the ++opt arguments that haven't yet been implemented. I'll update the comment in getTextToInsertFromFile().

Should I open an issue for implementing ++opt args, or just mention it in the roadmap?

[johnfn]

I'm okay with this not having ++opt, that can be a separate task. :)