Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoindent setting #726

Merged
merged 1 commit into from
Sep 7, 2016
Merged

Add autoindent setting #726

merged 1 commit into from
Sep 7, 2016

Conversation

octref
Copy link
Contributor

@octref octref commented Sep 6, 2016

Thought it didn't make it to 0.1.8 and was anxious :p

@johnfn

Yay! We love PRs! 🎊

Please include a description of your change & check your PR against this list, thanks:

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp tslint)

More info can be found by clicking the "guidelines for contributing" link above.

@rebornix
Copy link
Member

rebornix commented Sep 6, 2016

It's Okay that we miss the option in package.json as Code just wraps users configuration to an object (json to object) so everything works well except autocomplete for this option :)

},
"vim.autoindent": {
"type": "boolean",
"description": "Keep indentation when doing cc or S in normal mode to replace a line.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'd better use Vim's official description, see http://vimdoc.sourceforge.net/htmldoc/options.html#'autoindent'

@octref
Copy link
Contributor Author

octref commented Sep 7, 2016

@rebornix
Addressed. Take a look.

@rebornix
Copy link
Member

rebornix commented Sep 7, 2016

@octref thanks !

@rebornix rebornix merged commit 398e0da into VSCodeVim:master Sep 7, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants