Disable Vim Mode in Debug Repl

[rebornix]

Yay! We love PRs! 🎊

Please include a description of your change & check your PR against this list, thanks:

• Commit message has a short title & issue references
• Each commit does a logical chunk of work.
• It builds and tests pass (e.g gulp tslint)

This PR demonstrates the idea of disabling Vim keybindings in Debug Repl as Debug Repl is now inside the Editor Repl. It doesn't mean we have to merge this in, just want to show team how it works and what's the catch.

[jpoon]

Damn...that is a lot of if/else statements we need for this :(

[rebornix]

@jpoon yup, that's for other Code team members to see the dirty workaround with current Code behavior. It's real dirty.

[johnfn]

Can you do all of these just once inside keyPressed in modeHandler? Or is there something I'm missing?

[jpoon]

Can you do all of these just once inside keyPressed in modeHandler?

That's what I was thinking too. But, with the way the code is now, it shows how bad of a hack it is and VSCode should really fix it on their end

[rebornix]

@johnfn As we catch Code's keystrokes like Backspace, I don't know how to delegate back this keystroke to Code. If that's possible, then the solution is quite clean somehow. I may need to do some searching or maybe you guys already have ideas.

[jpoon]

I thought all keystrokes go through...

  async handleKeyEvent(key: string): Promise<Boolean> {

[johnfn]

it shows how bad of a hack it is and VSCode should really fix it on their end

If @rebornix's solution is really the only way to go about this, IMO it shows more that we architected our own code poorly. :/

(And by we I mean "I". I never really bothered to refactor extension.ts because I just wanted to pretend it didn't exist. :P)

[jpoon]

Related: #666

[rebornix]

@jpoon @johnfn now the code looks more reasonable :) We are going to mitigate this issue (like disabling debug panel from editor pane in extension host) this sprint but now this fix can get rid of the issue real quick, even though the additional inDebugRepl check is still dirty.

[jpoon]

Is it possible to move this check to a more central location? Maybe inside 'handlekey'?

[rebornix]

The catch is we can't delegate back modifiers like ctrl to Code, that's also why we need to put vim.mode != 'Insert Mode' here :(

I remembered you commented on similar issues on Code's issue list?

[jpoon]

Ah right. Brain fart.

Change is ugly :( but LGTM.

[jpoon]

Oh wait. Cause these ctrl modifiers are configured they should already go through handlekeys right?