Add commands support for 'gg' and 'G' #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Would you mind adding tests? See this as a reference. Regressions are starting to become an issue :( |
|
Tests have been added and functions are renamed to 'firstLineNonBlanChar' and 'lastLineNonBlanChar' to differentiate them from document begin and end functions. Please review. |
|
One last thing, can you squash your commits: |
…haracter; 'G': go to last line, on first non-blank character
|
Update: commits are squashed to a single one |
jpoon
added a commit
that referenced
this pull request
Dec 2, 2015
Add commands support for 'gg' and 'G'
|
👍 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add navigation commands support: