Fix race condition with switching active text editor. #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Ping @xconverge just in case you're curious. It's important that we use the TaskQueue as a global locking mechanism to ensure that two updates don't run simultaneously and cause weird issues. I should have noticed this when you submitted your PR, though; it's a bit of a subtle issue!) |
johnfn
force-pushed
the
fix-editor-race-condition
branch
from
b0e048a
to
51115be
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you
ctrl-w hinto another editor, the undo history states of the two editors would become intertwined. It could also cause VSCodeVim to crash if they were big enough, because it'd attempt to diff them against each other and take a really long time.