fix #690 and other toggle case issues #698
Conversation
| const text = TextEditor.getText(range); | ||
|
|
||
| let newText = ""; | ||
| for (var i = 0; i < text.length; i++) { |
There was a problem hiding this comment.
Can you refactor out this duplicated code?
There was a problem hiding this comment.
Yea I was waiting for this comment, I figured that this was better than polluting the other one with VisualBlock specific stuff.
Where would a function like this to DRY it up go?
There was a problem hiding this comment.
Haha, yeah, you know it had to happen. Maybe in a utilities file somewhere? Or if you can't find/dont want to make one, then a static method on a class can work.
| @@ -3537,20 +3537,55 @@ class ToggleCaseOperator extends BaseOperator { | |||
|
|
|||
| public async run(vimState: VimState, start: Position, end: Position): Promise<VimState> { | |||
| const range = new vscode.Range(start, new Position(end.line, end.character + 1)); | |||
There was a problem hiding this comment.
Can you also change this to: new vscode.Range(start, end.getRight());.
Probably doesn't matter but I'd sleep better at night with the position checking.
There was a problem hiding this comment.
Will do, insomnia is no fun
|
Pending @johnfn's comment. LGTM. |
|
Should be good to go |
|
@xconverge once you merge latest from |
Toggle case wasn't toggling interWoVen cases...
Also made it repeatable with dot and correctly