fix #510 #659
fix #510 #659
Conversation
|
So this works pretty well...however....it bombs on the tests. I tracked it to the fact that now that I am calling getAndUpdateModeHandler(), it will create modehandlers that have withTesting set to FALSE for the tests. Is there a way to disable this event handler for just the tests? :/ Any advice would be great... |
|
Can you move our isTesting flag to a global somewhere? That's something I should have done back when I made modehandler per-editor rather than global itself. |
|
where would be the best place to put a global like that in extension.ts? And then where is the top most level of testing where I could set it, testSimplifier.ts? |
|
You may actually want to start a new file called globals.ts and follow the same pattern i did in taskqueue.ts to export it. testSimplifier is OK, but not all of our tests use that infrastructure. Maybe there's a better place somewhere? Is it possible to latch onto when mocha starts running tests somehow? Some sort of global "before all tests" thing? I'm not sure! |
|
got it, let me know how it looks, works for me :) |
| @@ -12,6 +12,7 @@ import { showCmdLine } from './src/cmd_line/main'; | |||
| import { ModeHandler } from './src/mode/modeHandler'; | |||
| import { TaskQueue } from './src/taskQueue'; | |||
| import { Position } from './src/motion/position'; | |||
| import './src/globals'; | |||
There was a problem hiding this comment.
Instead of importing everything from globals into the namespace, can you do something like
import { globals } from './src/globals'
and then check globals.isTesting?
|
More small comments. |
|
Let me know if that hits any of the marks you were referring to... |
|
This looks great. Can you just fix up those merge conflicts and we should be good to go here. |
|
woops bad merge.. |
|
Another great change. 0.1.8 is shaping up to be the most bug free release in VSCodeVim history! (sort of.) |
We update everything better now when text editors are changed