Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special keys in Insert Mode #615

Merged
merged 5 commits into from
Sep 8, 2016
Merged

Conversation

rebornix
Copy link
Member

Yay! We love PRs! 🎊

Please include a description of your change & check your PR against this list, thanks:

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp tslint)

Add support for https://github.com/VSCodeVim/Vim/blob/master/ROADMAP.md#special-keys-in-insert-mode

let text: string;

if (typeof register.text === "object") {
text = (register.text as string []).join("\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cast is actually unnecessary here due to the magic of typescript 2.0 and discriminated union types! :)

@jpoon jpoon added the WIP label Aug 29, 2016
@rebornix rebornix force-pushed the SpecialKeys branch 2 times, most recently from a79fcc1 to 07f8e75 Compare September 6, 2016 21:24
@rebornix rebornix removed the WIP label Sep 6, 2016
@rebornix rebornix changed the title [WIP] Special keys in Insert Mode Special keys in Insert Mode Sep 6, 2016
@rebornix rebornix merged commit 94c0948 into VSCodeVim:master Sep 8, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants