Sentence selection #592
Merged
Sentence selection #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
force-pushed
the
SentenceSelection
branch
from
bbf1e68
to
949115a
Compare
| const currentSentenceNonWhitespaceEnd = currentSentenceBegin.getCurrentSentenceEnd(); | ||
|
|
||
| if (currentSentenceNonWhitespaceEnd.isBefore(position)) { | ||
| // The cursor is on a trailing white space. |
There was a problem hiding this comment.
The thing is Vim has a weird mechanism of handling leading or trailing spaces. The logic should be shared between words, sentences or paragraphs but since Vim is handling word, sentence and paragraph 's boundary differently, I still don't find a good way to reduce these redundant if-else statements. Will try later.
rebornix
force-pushed
the
SentenceSelection
branch
from
8774bac
to
577c255
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay! We love PRs! 🎊
Please include a description of your change & check your PR against this list, thanks:
gulp tslint)The code becomes complex when dealing with Vim' special logic of leading/trailing spaces handling.