Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix C or cc kill the empty line #591

Merged
merged 5 commits into from
Aug 11, 2016
Merged

fix C or cc kill the empty line #591

merged 5 commits into from
Aug 11, 2016

Conversation

shotaAkasaka
Copy link
Contributor

fixes #556

rebornix
rebornix reviewed Aug 11, 2016
View reviewed changes
src/actions/actions.ts
state.cursorPosition = state.cursorPosition.getRight();
} else {
state.currentMode = ModeName.Insert;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you want to move the delete operation here instead of isEndOfLine branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comment. it fixed bea29a2.

@johnfn johnfn merged commit 3424956 into VSCodeVim:master Aug 11, 2016
@johnfn
Copy link
Member

johnfn commented Aug 11, 2016

Great change! Thanks, @shotaAkasaka.

@shotaAkasaka shotaAkasaka deleted the C-cc-fix branch August 11, 2016 23:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C or cc will kill the empty line
3 participants
@shotaAkasaka @johnfn @rebornix