Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #571 #579

Merged
merged 1 commit into from
Aug 8, 2016
Merged

Fix for issue #571 #579

merged 1 commit into from
Aug 8, 2016

Conversation

xconverge
Copy link
Member

@xconverge xconverge commented Aug 8, 2016

Please include a description of your change & check your PR against this list, thanks:

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp tslint)

More info can be found by clicking the "guidelines for contributing" link above.

@johnfn
Copy link
Member

johnfn commented Aug 8, 2016

Awesome work - thanks, @xconverge!

@johnfn johnfn merged commit 23be73d into VSCodeVim:master Aug 8, 2016
@jpoon
Copy link
Member

jpoon commented Aug 8, 2016

@xconverge FYI, here's a neat trick: you can also seamlessly close the issue with your PR if you include one of these keywords from GH: https://help.github.com/articles/closing-issues-via-commit-messages/

@xconverge
Copy link
Member Author

xconverge commented Aug 8, 2016

@jpoon cool, will use that for the next one :)

So If my commit message was "Fixes #571 " it would have automatically closed the issue?

@jpoon
Copy link
Member

jpoon commented Aug 8, 2016

Yep! When you initially submit the PR, GH will automatically add a reference to the PR from the issue and when the PR is merged, GH will automatically close the referenced issue.

@xconverge xconverge deleted the fix-backwards-tilAndFind branch August 27, 2016 00:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants