Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack to mitigate #569 and prevent extension from locking up #576

Merged
merged 1 commit into from
Aug 6, 2016

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Aug 6, 2016

  • Small workaround to prevent extension from locking up when # on whitespace.
  • Adding gulp watch command to auto-compile things on file changes.

The current implementation of # and * do not current map to the expected behaviour of vim and will require more time to fix.

@jpoon jpoon merged commit 06c4906 into master Aug 6, 2016
@jpoon jpoon deleted the mitigate_569 branch August 6, 2016 01:33
@johnfn
Copy link
Member

johnfn commented Aug 6, 2016

Isn't this also needed for *?

On Sat, Aug 6, 2016 at 1:33 AM, Jason Poon [email protected] wrote:

Merged #576 #576.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#576 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAKPQcjuL2LAsbATgBu5SvLkCGlyfq2Oks5qc-RjgaJpZM4JeKw3
.

Grant

@jpoon
Copy link
Member Author

jpoon commented Aug 6, 2016

* wasn't ever hanging (never looked into why), so didn't add the hack there.

@johnfn
Copy link
Member

johnfn commented Aug 6, 2016

Ok, makes sense to me. 👍

On Sat, Aug 6, 2016 at 2:06 AM, Jason Poon [email protected] wrote:

  • wasn't ever hanging (never looked into why), so didn't add the hack
    there.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#576 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAKPQWZLK-Q0FIYXAXZFTGIyeIzWXptrks5qc-wggaJpZM4JeKw3
.

Grant

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants