Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binding of control-keys #575

Merged
merged 1 commit into from
Aug 6, 2016
Merged

Conversation

ascandella
Copy link
Contributor

Seems to be a regression from recent refactor. Tested manually in debug
extension. Prior to this commit, ctrl+a/ctrl+x didn't work. Now they do.

Seems to be a regression from recent refactor. Tested manually in debug
extension. Prior to this commit, ctrl+a/ctrl+x didn't work. Now they do.
@ascandella
Copy link
Contributor Author

cc @johnfn I think this was caused by e549933, since the key variable now already has the ctrl+ prefix in it.

@jpoon
Copy link
Member

jpoon commented Aug 6, 2016

@sectioneight beat me to it. thanks! 👍

@jpoon jpoon merged commit bb0b5df into VSCodeVim:master Aug 6, 2016
@johnfn
Copy link
Member

johnfn commented Aug 6, 2016

Oh yikes! Thanks. This is a testing blindspot unfortuantely.

@johnfn
Copy link
Member

johnfn commented Aug 6, 2016

Good thing you caught this before our next release...

@ascandella ascandella deleted the fix-control-bind branch August 6, 2016 00:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants