Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test regression #560

Merged
merged 1 commit into from
Aug 3, 2016
Merged

Fix test regression #560

merged 1 commit into from
Aug 3, 2016

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Aug 3, 2016

Yay! We love PRs! 🎊

Please include a description of your change & check your PR against this list, thanks:

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp tslint)

As title. Since we still have test failure in local (those god name ones), sometimes we fail to realize our code change brings more failure.

@rebornix
Copy link
Member Author

rebornix commented Aug 3, 2016

The first build job passed while the second said 1) register Can use two registers together: ... failed.

@jpoon
Copy link
Member

jpoon commented Aug 3, 2016

I restarted the failed build job. We'll see if that helps.

Update: nope, legit error.

@johnfn
Copy link
Member

johnfn commented Aug 3, 2016

Hmm, looks like it may be a real be unrelated bug on OSX. In any case, it's not related to this PR, which is fine. Thanks @rebornix!

@johnfn johnfn merged commit b7ec912 into VSCodeVim:master Aug 3, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants